Fix custom domain flow #2783
Fix custom domain flow #2783
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR refactors the custom domain verification flow to improve the user experience and fix issues in domain verification logic. The changes standardize how domain verification states are displayed and handled across the application.
Changes:
- Refactored domain verification logic to use
proxyRule.statusinstead of a simple boolean, with better handling of different states ('created', 'verifying', 'unverified', 'verified') - Updated UI components to show more informative status badges and messages for different domain verification states
- Added helper navigation callbacks to allow users to switch between different DNS record types (CNAME, A, AAAA, nameservers) with contextual alerts for apex domains
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| retryDomainModal.svelte | Refactored tab visibility logic and verification status handling, improved error states |
| studio.svelte | Changed siteId to derived state, updated to pass full ProxyRule objects instead of just IDs, added logic to show manage domains sheet on successful verification |
| domains/verify/view.svelte | Updated verification flow to always call updateRuleVerification, improved tab visibility logic, changed to use full rule object |
| domains/manage/table.svelte | Enhanced status badge display with more specific messages for different verification states, added inline retry links for failed verifications |
| domains/add/view.svelte | Changed verification success criteria and updated to pass full rule object to callback |
| tlds.ts | Added new getSubdomain helper function |
| recordTable.svelte | Added support for CAA records, improved apex domain handling with contextual alerts, enhanced status badge logic |
| nameserverTable.svelte | Changed badge type from "warning" to "error" for failed verifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes SER-1058